Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump versions and CI #621

Merged
merged 5 commits into from
Sep 27, 2023
Merged

Bump versions and CI #621

merged 5 commits into from
Sep 27, 2023

Conversation

wirew0rm
Copy link
Member

@wirew0rm wirew0rm commented Sep 26, 2023

  • bump the main java version from 11 to 17 and add a 21 build.
  • bump javafx to 16
    • all later versions trigger the memory leak check in our unittests. I followed it up to it being triggered by charts having at least one plugin, while an anonymous ChartPlugin does not trigger it. It seems to be triggered by the listener on the chartProperty having references to the chart in its Closure.
  • bump all other plugin references
    • except javadoc, which causes jigsaw/module-system related errors if updated to the most recent version.
  • update github actions to current versions.
  • address leftovers from the previous PRs
    • Measurements: remove unused indicators
    • UpdateAxisPlugin: disable for now since it was not completely implemented anyhow and has to be adapted to the event system
    • EditDataSet: recompute selector ui element positions on axis or data changes
    • CategoryAxis: reenable updating the labels from dataset labels

@pr-explainer-bot
Copy link

Pull Request Report

Hey there! 👋 Here's a report on the changes, suggestions, bugs, improvements, and rating for the pull request.

Changes

  1. Updated JAVA_REFERENCE_VERSION environment variable from 11 to 17 in .github/workflows/ci.yml.
  2. Added a new build for Java 21 in .github/workflows/ci.yml.
  3. Updated the actions/checkout version from v2 to v3 in .github/workflows/ci.yml and .github/workflows/coverity.yml.
  4. Updated the actions/cache version from v1 to v3 in .github/workflows/coverity.yml.
  5. Updated the actions/setup-java version from v2.1.0 to v3 in .github/workflows/coverity.yml.
  6. Updated the version of testfx-junit5 dependency from 4.0.16-alpha to 4.0.17 in chartfx-chart/pom.xml.
  7. Updated the version of maven-plugin-api dependency from 3.6.3 to 3.9.4 in chartfx-generate/pom.xml.
  8. Updated the version of maven-plugin-annotations dependency from 3.6.0 to 3.9.0 in chartfx-generate/pom.xml.
  9. Updated the version of jafama dependency from 2.3.1 to 2.3.2 in chartfx-math/pom.xml and chartfx-samples/pom.xml.
  10. Updated the maven.compiler.source and maven.compiler.target versions from 11 to 17 in pom.xml.
  11. Updated the version of commons-lang3 dependency from 3.12.0 to 3.13.0 in pom.xml.
  12. Updated the version of slf4j dependency from 2.0.6 to 2.0.9 in pom.xml.
  13. Updated the version of junit.jupiter dependency from 5.9.2 to 5.10.0 in pom.xml.
  14. Updated the version of jetbrains.annotations dependency from 21.0.1 to 24.0.1 in pom.xml.
  15. Updated the version of JMemoryBuddy dependency from 0.2.6 to 0.5.2 in pom.xml.

Suggestions

  • Consider providing more detailed commit messages to improve readability and understanding of the changes made.

Bugs

No bugs found.

Improvements

  • Refactor the code in a few places for better readability:
    • In chartfx-chart/pom.xml, update the testfx-junit5 version to 4.0.17:
      <dependency>
          <groupId>org.testfx</groupId>
          <artifactId>testfx-junit5</artifactId>
          <version>4.0.17</version>
          <scope>test</scope>
      </dependency>
    • In chartfx-generate/pom.xml, update the maven-plugin-api version to 3.9.4:
      <dependency>
          <groupId>org.apache.maven</groupId>
          <artifactId>maven-plugin-api</artifactId>
          <version>3.9.4</version>
      </dependency>
    • In chartfx-math/pom.xml and chartfx-samples/pom.xml, update the jafama version to 2.3.2:
      <dependency>
          <groupId>net.jafama</groupId>
          <artifactId>jafama</artifactId>
          <version>2.3.2</version>
          <scope>test</scope>
      </dependency>
    • In pom.xml, update the commons-lang3 version to 3.13.0:
      <version.commons-lang3>3.13.0</version.commons-lang3>
      Update the `

@sonarcloud
Copy link

sonarcloud bot commented Sep 27, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 4 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@wirew0rm wirew0rm merged commit 9508d3c into main Sep 27, 2023
10 checks passed
@wirew0rm wirew0rm deleted the bumpVersions branch September 27, 2023 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants