changed label setting to match 11.2.7 behavior

[ennerf]

I double checked the automatic axis-label setting, and the 11.2.7 behavior was that each renderer tries to use the first dataset. Once the labels get set, a boolean state ensures that the labels do not get overwritten later.

This PR changes the behavior to match the 11.2.7 release.

[sonarcloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
No Duplication information

[pr-explainer-bot]

Pull Request Report

Hey there! I've analyzed the pull request and here's the report for you:

Changes

1. Removed the import statement for io.fair_acc.chartfx.axes.spi.CategoryAxis in XYChart.java (line 5).
2. Removed the code block that updates categories for CategoryAxis in XYChart.java (lines 15-34).
3. Modified the condition in the updateCategories method of CategoryAxis.java (line 8).
4. Removed the isUsingAxis method from Renderer.java (lines 18-23).
5. Modified the updateAxes method in AbstractRendererXY.java to update categories for CategoryAxis (lines 14-19).
6. Removed the isUsingAxis method from AbstractRendererXY.java (lines 24-29).
7. Removed the isUsingAxis method from AbstractRendererXYZ.java (lines 6-10).

Suggestions

1. Consider adding comments to explain the purpose of the removed code blocks and methods.

Bugs

1. No bugs found.

Improvements

1. The code in XYChart.java (lines 15-34) can be refactored for better readability. Here's an improved version:

if (axis instanceof CategoryAxis catAxis) {
    for (Renderer renderer : getRenderers()) {
        if (renderer.isUsingAxis(axis) && !renderer.getDatasets().isEmpty()) {
            catAxis.updateCategories(renderer.getDatasets().get(0));
            break;
        }
    }
}

Rating

I would rate the code a 7 out of 10. The code is generally readable and performs well. However, there are some areas that could be improved for better readability and maintainability.

That's it for the report! Let me know if you need any further assistance. Cheers!

[codecov]

Codecov Report

Attention: 4 lines in your changes are missing coverage. Please review.

Comparison is base (9508d3c) 48.09% compared to head (5db1a9b) 48.09%.

Additional details and impacted files

@@            Coverage Diff            @@
##               main     #624   +/-   ##
=========================================
  Coverage     48.09%   48.09%           
- Complexity     6213     6215    +2     
=========================================
  Files           374      374           
  Lines         38299    38288   -11     
  Branches       6110     6105    -5     
=========================================
- Hits          18419    18416    -3     
- Misses        18721    18725    +4     
+ Partials       1159     1147   -12     

Files	Coverage Δ
...art/src/main/java/io/fair_acc/chartfx/XYChart.java	58.13% <ø> (+1.10%)	⬆️
...in/java/io/fair_acc/chartfx/renderer/Renderer.java	59.25% <ø> (+2.11%)	⬆️
..._acc/chartfx/renderer/spi/AbstractRendererXYZ.java	70.96% <ø> (+2.21%)	⬆️
...ava/io/fair_acc/chartfx/axes/spi/CategoryAxis.java	23.45% <0.00%> (-7.41%)	⬇️
...r_acc/chartfx/renderer/spi/AbstractRendererXY.java	83.60% <25.00%> (-0.77%)	⬇️

... and 4 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[wirew0rm]

thanks, looks good 👍