-
-
Notifications
You must be signed in to change notification settings - Fork 897
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add book module #2949
base: next
Are you sure you want to change the base?
feat: add book module #2949
Conversation
✅ Deploy Preview for fakerjs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## next #2949 +/- ##
==========================================
- Coverage 99.97% 99.96% -0.01%
==========================================
Files 2776 2792 +16
Lines 226338 227389 +1051
Branches 944 949 +5
==========================================
+ Hits 226285 227319 +1034
- Misses 53 70 +17
|
I know, sure, just asking :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Happy with the API I think it looks good overall!
Maybe we could have a few more books for the title method, I feel 100 is not that many. We normally cap any one data type at 1000. Perhaps we could get up to 200 books?
Non urgent as this probably won't get merged until 9.1
Ok I will add more book titles |
272e259
I have just added more book titles and authors (about 150 each). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll already approve. I still have the question if the addition of the polish locale should be it's own PR. That way there would be a separate entry on our reloase notes/changelog.
- Create book module (new modules have to have applicable locale data in the default locale => en)
- Add polish locale data for book module.
This is not blocking. Just a question on the process.
Edit: Also, thank you @cieslarmichal for the initial waiting, quick implementation and reasonable feedback loops. Was a pleasure reviewing your PR.
Initial data is initial data. |
I would say if it's only 2 or 3 locales included it's better to include in the initial commit. That helps verify there are no incorrect assumptions about how the data will be localised (for example in the first version of this PR the pl and en versions of author used different FirstName surname orders. That was good, as it helped us clarify what the rule should be in general and standardise it.) |
Thank you guys for a nice word :) It was a good review process, I am happy about it, can't wait to release those changes 😎 |
Added new Book module as discussed in #2310.
Changes made: