-
-
Notifications
You must be signed in to change notification settings - Fork 897
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
infra: replace tsup with packem #3094
base: next
Are you sure you want to change the base?
Conversation
✅ Deploy Preview for fakerjs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## next #3094 +/- ##
==========================================
+ Coverage 99.95% 99.96% +0.01%
==========================================
Files 2776 2776
Lines 226260 226260
Branches 587 593 +6
==========================================
+ Hits 226164 226187 +23
+ Misses 96 73 -23 |
Node10 works fine for me, what needs to be fixed? |
shini wanted that i split this MR into 2 -> shini did open new prs with the changes.
|
|
"types": "./dist/index.d.cts", | ||
"default": "./dist/index.cjs" | ||
}, | ||
"import": { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
suggestion: IMO this should be default, just to be really safe and we don't forget any unpopular exports (e.g. "node" or "browser")
better they ship incompatible versions but could be worked around somehow, as instead they are not shipped at all
same for line 132
I get the following warning during build:
type Casing = 'upper' | 'lower' | 'mixed';
[...]
type Casing$1 = 'lower' | 'upper' | 'mixed'; |
I get the following error during playground build:
|
The build process also edits my package.json: "typesVersions": {
">=5.0": {
".": [
- "./dist/index.d.ts"
+ "./dist\\index.d.ts"
],
"locale/*": [
- "./dist/locale/*.d.ts"
+ "./dist\\locale\\*.d.ts"
]
}
}, |
Team Decision We will first merge #3093, but we keep this as an alternative once the remaining issues are resolved. |
This is a different approach to fix #3087
npm notice package size: 2.1 MB
npm notice unpacked size: 8.6 MB
tonpm notice package size: 2.0 MB
npm notice unpacked size: 6.8 MB
(hard to display, the newest version has more type files..) -> runnpm pack --dry-run
to validate itnode10
node16 (from CJS)
node16 (from ESM)
bundler
node10
node16 (from CJS)
node16 (from ESM)
bundler
node10
node16 (from CJS)
node16 (from ESM)
bundler
typesVersions
are generated based on https://github.com/andrewbranch/example-subpath-exports-ts-compat/tree/main/examples/node_modules/types-versions-wildcards, this is handle bypackem