Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

infra: publish releases with provenance #3119

Merged
merged 3 commits into from
Sep 17, 2024
Merged

Conversation

ST-DDT
Copy link
Member

@ST-DDT ST-DDT commented Sep 16, 2024

This PR adds release providence to our releases on npm.

Example:

{FF85472C-BA5B-4A54-B066-1852C76586BC}

I haven't tested the pipeline changes myself, but I verified with various other libraries, that the syntax should work.

I decided to use an ENV variable to set the flag as I consider it easier to read than the other alternatives (--flag, .npmrc).
Also it does not prevent publishing from our own computers, if ever needed again.

Example projects

See also

@ST-DDT ST-DDT added p: 1-normal Nothing urgent c: infra Changes to our infrastructure or project setup labels Sep 16, 2024
@ST-DDT ST-DDT added this to the vAnytime milestone Sep 16, 2024
@ST-DDT ST-DDT requested review from a team September 16, 2024 08:56
@ST-DDT ST-DDT self-assigned this Sep 16, 2024
Copy link

netlify bot commented Sep 16, 2024

Deploy Preview for fakerjs ready!

Name Link
🔨 Latest commit 7bf7119
🔍 Latest deploy log https://app.netlify.com/sites/fakerjs/deploys/66e966a7f8c50c000860cdcb
😎 Deploy Preview https://deploy-preview-3119.fakerjs.dev
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Sep 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.97%. Comparing base (48f171e) to head (7bf7119).
Report is 1 commits behind head on next.

Additional details and impacted files
@@            Coverage Diff             @@
##             next    #3119      +/-   ##
==========================================
- Coverage   99.97%   99.97%   -0.01%     
==========================================
  Files        2776     2776              
  Lines      226338   226338              
  Branches      944      943       -1     
==========================================
- Hits       226285   226274      -11     
- Misses         53       64      +11     

see 1 file with indirect coverage changes

Copy link
Member

@Shinigami92 Shinigami92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool

@ST-DDT ST-DDT requested a review from a team September 16, 2024 09:32
@ST-DDT ST-DDT enabled auto-merge (squash) September 17, 2024 11:23
@ST-DDT ST-DDT merged commit 548c034 into next Sep 17, 2024
21 checks passed
@ST-DDT ST-DDT deleted the infra/npm/release-provenance branch September 17, 2024 11:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c: infra Changes to our infrastructure or project setup p: 1-normal Nothing urgent
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants