Conversation
isidentical
left a comment
There was a problem hiding this comment.
Wow, fast PR @chamini2! Quick question, do you think it makes sense to add some except_handler stuff around the places where we actually write data since we now use a more unified connection?
turbo1912
left a comment
There was a problem hiding this comment.
you should also remove the new_connection calls here
https://github.com/fal-ai/fal/blob/act1/adapter/src/dbt/adapters/fal/teleport/snowflake.py#L13-L50
34043e8 to
532e94f
Compare
Well, we don't really want to handle the exceptions, right? if it fails, it just fails and the model shows ERROR as status. Or am I missing something? |
I meant let the DBT handle those exceptions, not us. E.g. calling |
Tested it against jaffle_shop_with_fal. Please do more tests either way.