This repository was archived by the owner on Apr 8, 2024. It is now read-only.
support dbt-core between 1.6.0 to 1.7.8#919
Open
salimmoulouel wants to merge 2 commits intofal-ai:mainfrom
Open
support dbt-core between 1.6.0 to 1.7.8#919salimmoulouel wants to merge 2 commits intofal-ai:mainfrom
salimmoulouel wants to merge 2 commits intofal-ai:mainfrom
Conversation
salimmoulouel
force-pushed
the
feature/support_dbt_core1.7.x
branch
from
068e065 to
9463fad
Compare
Author
salimmoulouel
changed the title
mederka
reviewed
Feb 27, 2024
Collaborator
mederka
left a comment
mederka
left a comment
There was a problem hiding this comment.
Thank you for your contribution @salimmoulouel! Did you run any of repository tests on your local system? You can run them with behave. We need to see at least the postgres tests passing.
For an example on how to setup and run tests, you can look here:
https://github.com/fal-ai/dbt-fal/blob/main/.github/workflows/test_integration_adapter.yml
Author
|
@mederka i tried to understand the tests, it seem complicated for me, can i have more details on how to do the test locally please, i'm sorry in advance i'm new in the open source community :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
resolves
#909
#880
#914
Integration tests
Adapter to test:
Python version to test: