Quality: Broken directory existence check due to missing method call#2615
Merged
CaselIT merged 1 commit intofalconry:masterfrom Apr 5, 2026
Conversation
The code checks `content.is_dir` instead of calling `content.is_dir()`. Since bound method objects are always truthy, the assertion never validates extraction output and can mask packaging/extraction failures. Affected files: tox_sdist.py Signed-off-by: tuanaiseo <221258316+tuanaiseo@users.noreply.github.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #2615 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 64 64
Lines 7914 7914
Branches 1087 1087
=========================================
Hits 7914 7914 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Member
|
the fails don't seem related to this PR, so merging |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The code checks
content.is_dirinstead of callingcontent.is_dir(). Since bound method objects are always truthy, the assertion never validates extraction output and can mask packaging/extraction failures.Severity:
highFile:
tools/tox_sdist.pySolution
Replace
assert content.is_dir, ...withassert content.is_dir(), ...so the check validates the extracted directory correctly.Changes
tools/tox_sdist.py(modified)Testing