fix(skills): clean up orphaned database records when skill directory is missing#2326
Open
wucm667 wants to merge 2 commits intofarion1231:mainfrom
Open
fix(skills): clean up orphaned database records when skill directory is missing#2326wucm667 wants to merge 2 commits intofarion1231:mainfrom
wucm667 wants to merge 2 commits intofarion1231:mainfrom
Conversation
…is missing When users manually delete skill directories from the filesystem, get_all_installed() now detects orphaned database records and removes them automatically. Adds a safety check to skip cleanup if the SSOT directory itself is inaccessible. Fixes farion1231#2279
Owner
|
@codex review |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 3c26b1a4d7
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
…cidental deletions
Author
|
@codex review |
|
To use Codex here, create a Codex account and connect to github. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem / 问题
When users manually delete skill directories from the filesystem (e.g.,
~/.cc-switch/skills/,~/.claude/skills/,~/.codex/skills/), the CC Switch client still displays these deleted skills becauseget_all_installed()only reads from the database without verifying that the skill directory exists on disk.Closes #2279
Solution / 解决方案
Modified
get_all_installed()insrc-tauri/src/services/skill.rsto:Safety / 安全性
get_all_installedfunction is modified — no changes to uninstall, install, or database logicFiles Changed / 文件变更
src-tauri/src/services/skill.rs—get_all_installed()function (+27/-1)