perf: speed up high-precision parsing - #21
Open
Colerar wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Main change
The parser previously scanned fractional digits twice:
This change stops the forward pass as soon as it reaches the decimal point. The rev pass now also validates characters.
Benchmark
run on my M5 Pro (6 S, 12 P)
diff (vs 8580293):
high-precision-binaryhigh-precision-decimalsmall-fractionfractiongroupedmalformedbinary-unitu64-maxplaindecimal-unitIMO, the changes in
plainand/ordecimal-unitare probably measurement noise. It’s a rough comparison anyway, given the mbp’s big.little architecture and dynamic frequency scaling.idk if the changes differ across different architectures, such as
x86_64.raw data
before:
after:
related
PR: #20
Issue: #2