✨ Added passthrough for reload_dir option to uvicorn #160
+21
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JoelYoung01
changed the title
|
Looks like I can't add labels. Figured maybe the autolabeler read the emojis lol, that would be neat. Everything else should be fine, just need a label to be added. |
|
thats not it #36 i even tried to fix auto labeler.. with no luck |
|
Womp womp for us I guess haha. Guessing @tiangolo has to add labels himself (or anyone with accesss I suppose) |
|
Just wanna say it'd be awesome if this got merged in! I was thinking about writing a PR to do exactly this, then I saw it was already done :) |
|
Revisiting this PR to see if anything has changed. Just to make sure I'm not blind or something I tried adding labels via the gh cli, got this error: gh pr edit 160 --add-label feature
GraphQL: JoelYoung01 does not have the correct permissions to execute `AddLabelsToLabelable` (addLabelsToLabelable)Would love to see this merged! |
|
This pull request has a merge conflict that needs to be resolved. |
github-actions
bot
added
the
conflicts
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added the ability to pass reload-dir option to uvicorn run command.