Skip to content

💚 Fix test matrix and include testing on Windows and MacOS #1290

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 8 commits into from
Closed

💚 Fix test matrix and include testing on Windows and MacOS #1290

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
4dcfebf
Test matrix including different os's
svlandeg Feb 7, 2025
1097b9a
Add OS version to coverage file to avoid duplicates
svlandeg Feb 7, 2025
68093d3
Add a macos test for Python 3.9
svlandeg Feb 7, 2025
4d82a5f
set env to ensure test works well on Windows
svlandeg Feb 7, 2025
d2c7f14
attempt to skip empty files
svlandeg Feb 7, 2025
881a242
remove windows testing (for now) to check whether that fixes the cove…
svlandeg Feb 10, 2025
d80d39c
reverting further to see when the coverage issue stops popping up
svlandeg Feb 10, 2025
3683de1
push CI
svlandeg Feb 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 23 additions & 8 deletions .github/workflows/test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,17 +26,32 @@ jobs:
runs-on: ubuntu-latest
strategy:
matrix:
python-version:
- "3.7"
- "3.8"
- "3.9"
- "3.10"
- "3.11"
- "3.12"
os: ubuntu-latest
python-version: [ "3.12" ]
pydantic-version:
- pydantic-v1
- pydantic-v2
# include:
# - os: ubuntu-22.04
# python-version: "3.7"
# pydantic-version: pydantic-v1
# - os: ubuntu-22.04
# python-version: "3.7"
# pydantic-version: pydantic-v2
# - os: macos-latest
# python-version: "3.8"
# pydantic-version: pydantic-v1
# - os: ubuntu-latest
# python-version: "3.9"
# pydantic-version: pydantic-v2
# - os: ubuntu-latest
# python-version: "3.10"
# pydantic-version: pydantic-v1
# - os: macos-latest
# python-version: "3.11"
# pydantic-version: pydantic-v2
fail-fast: false
# runs-on: ${{ matrix.os }}
steps:
- uses: actions/checkout@v4
- name: Set up Python
Expand Down Expand Up @@ -78,7 +93,7 @@ jobs:
- name: Store coverage files
uses: actions/upload-artifact@v4
with:
name: coverage-${{ matrix.python-version }}-${{ matrix.pydantic-version }}
name: coverage-${{ matrix.os }}-${{ matrix.python-version }}-${{ matrix.pydantic-version }}
path: coverage
include-hidden-files: true

Expand Down
5 changes: 3 additions & 2 deletions tests/test_select_gen.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
import os
import subprocess
import sys
from pathlib import Path
Expand All @@ -10,8 +11,8 @@
@needs_py39
def test_select_gen() -> None:
result = subprocess.run(
[sys.executable, "scripts/generate_select.py"],
env={"CHECK_JINJA": "1"},
[sys.executable, Path("scripts") / "generate_select.py"],
env={**os.environ, "CHECK_JINJA": "1"},
check=True,
cwd=root_path,
capture_output=True,
Expand Down