📝 Make darkmode logo work on github #909
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pypae
changed the title
|
📝 Docs preview for commit 8ee3e7e at: https://cd0e35e6.typertiangolo.pages.dev |
|
Thanks for the PR, @pypae! We'll review this and get back to you 🙏 |
github-actions
bot
added
docs
|
📝 Docs preview for commit 6172210 at: https://1581077f.typertiangolo.pages.dev Modified Pages |
svlandeg
removed
docs
|
📝 Docs preview for commit dda7134 at: https://7791d569.typertiangolo.pages.dev Modified Pages |
|
@tiangolo : I think it's probably better if you review this one directly 🙏 |
|
Thanks @pypae! I tried a looot of things to make it compatible with both MkDocs and GitHub 😅 As I want to be able to keep both files in sync. For now, I would prefer to leave it as is, but thanks for the effort! ☕ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes the new dark mode logo introduced in #907 available in the GitHub README by using
<picture>conditionally.Note: This got quite ugly, because mkdocs material allows to override the system setting for darkmode, while on github we can only use the media query. Feel free to ignore and close.