add soar packages count

[QaidVoid]

Support for counting packages installed using soar package manager: https://github.com/pkgforge/soar

[CarterLi]

Thanks for your contribution. I'd like to merge it after your package manager getting more famous

[Twig6943]

@CarterLi this pkg manager legit gonna be the way to install appimages (the rest is either dead or not as feature complete)

[Azathothas]

Thanks for your contribution. I'd like to merge it after your package manager getting more famous

Understood.
In the meantime, we will build the forked version for our users

[Azathothas]

Hi, @CarterLi
What's the criteria for accepting this PR?
Currently, we have ~ 270 stars: https://github.com/pkgforge/soar/stargazers
How many more are needed, as it is a pain for our Users to have to use forked fastfetch instead of official

[Copilot]

Copilot reviewed 4 out of 6 changed files in this pull request and generated 1 comment.

Files not reviewed (2)

• CMakeLists.txt: Language not supported
• doc/json_schema.json: Language not supported

[Copilot]

SQLite3 does not include a built-in CONCAT function by default. Consider using the concatenation operator (pkg_id || pkg_name) to combine the fields.

Suggested change

	result->soar += getSQLite3Int(&baseDir, ".local/share/soar/db/soar.db", "SELECT COUNT(DISTINCT CONCAT(pkg_id, pkg_name)) FROM packages WHERE is_installed = true", "soar");
	result->soar += getSQLite3Int(&baseDir, ".local/share/soar/db/soar.db", "SELECT COUNT(DISTINCT pkg_id || pkg_name) FROM packages WHERE is_installed = true", "soar");

[CarterLi]

Is it necessary to use DISTINCT CONCAT(pkg_id, pkg_name) instead of just DISTINCT pkg_id?

[QaidVoid]

The same pkg_id can be associated with multiple packages, and similarly, the same pkg_name can appear with different pkg_id. So, the combination of pkg_id and pkg_name determines the unique package.

[CarterLi]

What about CONCAT and ||?

[CarterLi]

CI failed.

[QaidVoid]

It seems that we've exceeded the maximum capacity of 32 flags within the bounds of uint32_t. Changing the assertion to compare against sizeof(uint64_t) works, but to properly support additional flags, the entire enum must be converted to use uint64_t. However, I'm not sure if it has any compatibility issues on 32-bit architecture.

Do you have any suggestions?

[CarterLi]

It's ok to convert it to uint64_t