Skip to content

[CDTOOL-1288] Add support for Logging Endpoint Errors#800

Merged
rcaril merged 4 commits intomainfrom
rcaril/CDTOOL-1288-endpoint-error-streaming-support
Apr 8, 2026
Merged

[CDTOOL-1288] Add support for Logging Endpoint Errors#800
rcaril merged 4 commits intomainfrom
rcaril/CDTOOL-1288-endpoint-error-streaming-support

Conversation

@rcaril
Copy link
Copy Markdown
Member

@rcaril rcaril commented Apr 7, 2026

Change summary

This PR adds support for the Logging Endpoint Errors GET endpoint.

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?

New Feature Submissions:

  • Does your submission pass tests?

Changes to Core Features:

  • Have you written new tests for your core changes, as applicable?
  • Have you successfully run tests with your changes locally?

Comment thread fastly/observability_logging_endpoint_errors.go
@rcaril rcaril marked this pull request as ready for review April 7, 2026 19:13
@rcaril rcaril requested a review from a team as a code owner April 7, 2026 19:13
@rcaril
Copy link
Copy Markdown
Member Author

rcaril commented Apr 7, 2026

Adding in @kpfleming to validate that the product naming is as expected, as this wasn't super clear.

Copy link
Copy Markdown
Member

@kpfleming kpfleming left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes will need to be made once the API implementation is corrected.

Comment thread fastly/observability_logging_endpoint_errors.go
Comment thread fastly/observability_endpoint_error_stream.go Outdated
The API was recently patched to replace the single letter json placeholders - we updated this struct accordingly.

The file names were also updated to match the product name.
@rcaril
Copy link
Copy Markdown
Member Author

rcaril commented Apr 8, 2026

Recreated fixtures to represent the API changes in 1a538f2.

@rcaril rcaril requested a review from kpfleming April 8, 2026 17:35
@rcaril rcaril merged commit 84f3d3a into main Apr 8, 2026
8 checks passed
@rcaril rcaril deleted the rcaril/CDTOOL-1288-endpoint-error-streaming-support branch April 8, 2026 17:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants