[CDTOOL-1321] Add DNS Zones and TSIG Keys Support#805
Merged
Conversation
- Add CRUD and paginated list operations for /dns/v1/zones - Add CRUD and paginated list operations for /dns/v1/tsig-keys - Add ErrMissingAlgorithm to fastly/errors.go
rcaril
force-pushed
the
rcaril/CDTOOL-1321-dns-support
branch
from
78b28ad to
3fc4199
Compare
jedisct1
requested changes
May 5, 2026
…' to 'null' via the new 'Nullable' helper
Member
Author
|
Since I added a new helper function i'm looping in @kpfleming to eyeball this PR. |
kpfleming
reviewed
May 5, 2026
jedisct1
approved these changes
May 6, 2026
kpfleming
approved these changes
May 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change summary
This PR adds support for Fastly DNS Zones and TSIG Keys.
All Submissions:
New Feature Submissions:
Changes to Core Features:
Notes:
Added a generic
Nullable[T]helper tofastly/helpers.goto support fields that need to distinguish between "omit from request" and "explicitly set to null". This was specifically needed to support theinbound_tsig_key_idfield.Internal conversation on this can be found here.