SonicTriton: implement RetryActionDiffServer via TritonService; add tests and cfg support #22
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR description:
RetryActionDiffServer
for SonicTriton usingTritonService
’s server registry; remove per-action alternate server parameters.TritonClient::updateServer(TritonService::Server::fallbackName)
to switch servers on retry, per review guidance.HeterogeneousCore/SonicTriton/test/test_RetryActionDiffServer.cc
(arms → updateServer(fallback) → no-op on second retry → exception path is caught).HeterogeneousCore/SonicTriton/test/tritonTest_cfg.py
with--retryAction {same,diff}
and a verbose confirmation line.TestHeterogeneousCoreSonicTritonRetryActionDiff_Log
to assert the selected retry policy.HeterogeneousCore/SonicTriton/test/BuildFile.xml
(remove package-level test entries; use proper<bin>
withcatch2
).TritonClient
(test double support), removing the unused testing flag constructor.PR validation:
CMSSW_15_1_0_pre3
area:scram b -j 8
scram b runtests TEST=HeterogeneousCore/SonicTriton
(passes)same
anddiff
policies.Client.Retry
is explicitly configured.Backport:
CMSSW_15_0_X
after this PR is reviewed.