-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New feature CALL_ON_GLOBAL
, new global objects and functions related definitions
#53
Conversation
Thanks for the PR. How did you test these definitions? They're all failing for me. Even just running |
I just simulate it with |
as someone mentioned in 2012, |
should I close this PR now? or should I do anything else? |
Maybe
I appreciate the idea of this PR but I don't think that JScrewIt would run on such old browsers. Feel free to close if you don't have any other use cases. |
AFAIK from caniuse.com, Android browser 4.0 does not support zero-width chars in identifiers & Immutable undefined. so I reopened the PR, but I still don't know how to simulate. |
I use Android Studio on Windows x64 to emulate old Android devices. Then I usually start a server on the host from the JScrewIt folder, and enter the URL http://10.0.2.2/JScrewIt.html in Android browser. I haven't been able to check this PR yet. |
so, what should I do now? |
should I do some change to the makefile? or just leave that for you? |
Sorry, being a little busy at the moment. I checked on Android Browser 4.0 and |
should I change |
|
according to MDN, |
Yes, those are IFRAME objects.
We can't introduce side effects in the code. If |
just tried |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This works, thanks!
Just added |
CALL_ON_GLOBAL
, new definitions of "W" and "w"CALL_ON_GLOBAL
, new global objects and functions definitions
CALL_ON_GLOBAL
, new global objects and functions definitionsCALL_ON_GLOBAL
, new global objects and functions related definitions
Co-authored-by: Francesco Trotta <[email protected]>
Co-authored-by: Francesco Trotta <[email protected]>
Co-authored-by: Francesco Trotta <[email protected]>
Co-authored-by: Francesco Trotta <[email protected]>
IDK how to simulate it, tho.