Fix SSH tunnel gateway binding address issue #4900 - #4902
Merged
Conversation
Contributor
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
- Fix SSH tunnel gateway incorrectly binding to proxyBindAddr instead of bindAddr - This caused external connections to fail when proxyBindAddr was set to 127.0.0.1 - SSH tunnel gateway now correctly binds to bindAddr for external accessibility - Update Release.md with bug fix description Co-Authored-By: fatedier <fatedier@gmail.com>
devin-ai-integration
Bot
force-pushed
the
devin/1753685736-fix-ssh-gateway-bindaddr
branch
from
July 28, 2025 07:15
632dd46 to
42ab433
Compare
nebulabox
added a commit
to nebulabox/frp
that referenced
this pull request
Sep 9, 2025
* commit '22ae8166d31d39e09fe2d06f82d23b4433c49a33': (129 commits) bump version to v0.64.0 (fatedier#4924) improve random TLS certificate generation (fatedier#4923) update sponsor info (fatedier#4917) Fix SSH tunnel gateway binding address issue fatedier#4900 (fatedier#4902) update golangci-lint version (fatedier#4897) fix webserver port not being released on frpc svr.Close() (fatedier#4896) add tokenSource support for auth configuration (fatedier#4865) Update quic-go dependency from v0.48.2 to v0.53.0 (fatedier#4862) update .golangci.yml (fatedier#4848) update golangci-lint version (fatedier#4817) update test package (fatedier#4814) add proxy protocol support for UDP proxies (fatedier#4810) feat: support YAML merge in strict configuration mode (fatedier#4809) fix: type error in server_plugin doc (fatedier#4799) build: add x64 openbsd (fatedier#4780) update release notes (fatedier#4772) vnet: fix issues (fatedier#4771) update feature gates doc (fatedier#4755) vnet: update tun_unsupported function (fatedier#4752) virtual-net: initial (fatedier#4751) ... # Conflicts: # .github/workflows/build-and-push-image.yml # .github/workflows/golangci-lint.yml # .github/workflows/goreleaser.yml # .github/workflows/stale.yml # pkg/util/version/version.go
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WHY
Fixes #4900 where SSH tunnel gateway fails to accept external connections when
proxyBindAddris set to "127.0.0.1".Root Cause: SSH tunnel gateway was incorrectly binding to
cfg.ProxyBindAddrinstead ofcfg.BindAddr, causing it to only listen on localhost whenproxyBindAddr = "127.0.0.1".Solution: Changed SSH gateway initialization to use
cfg.BindAddrfor external accessibility while preservingproxyBindAddrfunctionality for actual proxy connections.WHAT
Main Change:
server/service.goline 265 to usecfg.BindAddrinstead ofcfg.ProxyBindAddrfor SSH tunnel gateway bindingSupporting Changes:
Release.mdwith fix description following project conventionsVERIFICATION
Local Testing Results:
0.0.0.0:60000instead of127.0.0.1:60000with test config:Behavior Change:
proxyBindAddr, rejecting external connections when set to "127.0.0.1"bindAddrfor external accessibilityREVIEW CHECKLIST
Critical Items:
server/service.golines 265-266 before mergeproxyBindAddrconfigurationsproxyBindAddr(user requirement)Additional Verification:
proxyBindAddr = "127.0.0.1"Link to Devin run: https://app.devin.ai/sessions/05cd89122d014c468428f66f349fcaa9
Requested by: @fatedier
Related Issue: #4900