Comment subscription emails should not respect HTTPS. Fixes #598#705
Open
johnnyshields wants to merge 2 commits intofatfreecrm:masterfrom
Open
Comment subscription emails should not respect HTTPS. Fixes #598#705johnnyshields wants to merge 2 commits intofatfreecrm:masterfrom
johnnyshields wants to merge 2 commits intofatfreecrm:masterfrom
Conversation
Contributor
johnnyshields
commented
Jan 19, 2018
johnnyshields
commented
- Also adds rb-readline to Gemfile for rails console
- Needs tests
…m#598 Also adds rb-readline to Gemfile for rails console Needs tests
CloCkWeRX
approved these changes
Jan 19, 2018
Contributor
Author
|
@DmitryAvramec please add tests for this. |
Contributor
Author
|
The patch in this PR should be applied in the URL helper. See comment in rails/rails#31746 |
Member
|
@johnnyshields id be happy to work on the tests. can you elaborate a bit more on what these tests are looking for. |
johnbumgardner
approved these changes
Jun 14, 2021
Member
|
Minor conflicts, if you can rebase... or I'll pick it up. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.