Skip to content

Commit

Permalink
Remove loop argument from aiokafka driver (#641)
Browse files Browse the repository at this point in the history
* removed loop arg

* restore double dict

* re-add comma

* tests

---------

Co-authored-by: didimelli <[email protected]>
  • Loading branch information
didimelli and didimelli committed Aug 13, 2024
1 parent 232c4cf commit a50e525
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 2 deletions.
1 change: 0 additions & 1 deletion faust/transport/drivers/aiokafka.py
Original file line number Diff line number Diff line change
Expand Up @@ -1242,7 +1242,6 @@ def _new_producer(
self, transactional_id: Optional[str] = None
) -> aiokafka.AIOKafkaProducer:
return self._producer_type(
loop=self.loop,
**{
**self._settings_default(),
**self._settings_auth(),
Expand Down
1 change: 0 additions & 1 deletion tests/unit/transport/drivers/test_aiokafka.py
Original file line number Diff line number Diff line change
Expand Up @@ -1391,7 +1391,6 @@ def assert_new_producer(
max_request_size=max_request_size,
compression_type=compression_type,
security_protocol=security_protocol,
loop=producer.loop,
partitioner=producer.partitioner,
transactional_id=None,
api_version=api_version,
Expand Down

0 comments on commit a50e525

Please sign in to comment.