-
Notifications
You must be signed in to change notification settings - Fork 183
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix table restoration for compacted changelogs #373
base: master
Are you sure you want to change the base?
Conversation
@elrik75 how about giving this a try? Apparently the |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #373 +/- ##
=======================================
Coverage 94.08% 94.08%
=======================================
Files 102 102
Lines 11117 11117
Branches 1550 1550
=======================================
Hits 10459 10459
Misses 558 558
Partials 100 100 ☔ View full report in Codecov by Sentry. |
We'll need to test this further before merging. |
I reviewed the code and the problem is much deeper than the changes here. |
This bug still exists. I recently lost my rocks-db disk and Faust started and launched the recovery. Once again some changelogs partitions did not start (they have an offset equal to the first Kafka offset - 1). Removing the |
In that case, I'll reopen the PR as a reminder for me to investigate this. |
Fixes #176.