Improve the control switch options for devices with timed charge/discharge #18
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have attempted to clean up the list of
energy_storage_control_switchmodes for inverters that support the timed charge/discharge, giving them more consistent names as well as attempting to order them more logically.As part of this I've also attempted to add a few missing options based on the below table
Key changes
19Self-Use with Backup - Allow Timed Charge/Discharge, No Grid Charging66Feed-in Priority - No Grid Charging, Allow Timed Charge/Discharge,80,82,112114Which are theFeed-in Priority with Backupmodels (some were available for inverters without the time charge/discharge but were missing for this model.@fboundy - Any chance I could bother you to sanity check my work on the extra modes? I believe these all make sense (and match the options available in solis), but wasn't sure if there was a reason some were avoided initially.