記事URLをblog-entry-{id}.html形式に変更 - #226
Merged
fc2dev merged 10 commits intoFeb 8, 2021
Merged
Conversation
- e2e test be fail caused by anchor tag that like`a src="#" onclick="form.submit()"`. - Puppeteer's waitForNavigation() will be return null when with click() that element, Not return a Response object. - If use timer for waiting, test will work. but not neat. - My guessing. When click the a tag (`src="#"`) by pupp, will be run waitForNavigation on not wanted timing. - So, cancel a event in onclick event.
It is a runnable, but will be conflicts with blog_crawl.test.ts when run in parallel now(WIP). Have to decoupling a entry(comment) id.
…wl and blog_crawl_sp.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#221
#225 を先にマージしてください
App::userURL修正NOTE
fc2blogはcanonicalがないようだが、いくつか見て回ってもないので必須ではないと判断。
（スマホで一部canonicalにするとややこしそうな箇所はある（コメント一覧など））
作業時間 1.2h