-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
管理画面操作時のAjax通信エラーについて、エラーダイアログ等をできるだけ出すように修正 #238
Merged
fc2dev
merged 18 commits into
fc2blog:master
from
uzulla:issue140/improve-js-error-handling-in-admin-page
Feb 28, 2021
Merged
管理画面操作時のAjax通信エラーについて、エラーダイアログ等をできるだけ出すように修正 #238
fc2dev
merged 18 commits into
fc2blog:master
from
uzulla:issue140/improve-js-error-handling-in-admin-page
Feb 28, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ref: #140
(#232 を先にマージしてください
$.ajax
や$(〜).load
の処理にエラーハンドリングがなく、通信エラー時などにユーザーが気づけ無いことがあるため、パーシャルロードされるコンテンツやalertにてエラーが発生したことをユーザーに掲示するようにした。また、一部
$('#sys-add-media-load').load(addMedia.load({keyword: keyword}));
などの意図が不明な処理を削減した。作業時間 3h