fix action label empty for multi-switch without reset#140
Merged
wengxt merged 1 commit intofcitx:masterfrom Jul 31, 2025
Merged
fix action label empty for multi-switch without reset#140wengxt merged 1 commit intofcitx:masterfrom
wengxt merged 1 commit intofcitx:masterfrom
Conversation
MokOopsing
pushed a commit
to MokOopsing/fcitx5-rime
that referenced
this pull request
Dec 24, 2025
This was referenced Apr 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reproduce: use https://github.com/amzxyz/rime_wanxiang, in status area the label for tone is empty. This is because there is no reset like rime-cantonese.
However, pressing F4/Ctrl+
then 2 to show rime's options, there is a checkmark after the first optionraw_input`, which is the result of GetSelectedOption.So adopt this behavior as well.