Skip to content

Conversation

@allape
Copy link
Contributor

@allape allape commented Dec 20, 2024

@drakkan
Copy link
Collaborator

drakkan commented Dec 20, 2024

Thanks for this contribution. It is ok for me. If you can, please add a simple test case, for example within the existing test for the SIZE command.

@codecov
Copy link

codecov bot commented Dec 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.68%. Comparing base (fef7c7b) to head (97608b4).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #501      +/-   ##
==========================================
+ Coverage   86.66%   86.68%   +0.02%     
==========================================
  Files          11       11              
  Lines        2324     2328       +4     
==========================================
+ Hits         2014     2018       +4     
  Misses        236      236              
  Partials       74       74              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@allape
Copy link
Contributor Author

allape commented Dec 21, 2024

Sure! And I add the test case for file in folder, which makes func ftpUpload broken in file transfer_test.go, and I add the secondary condition to make it work

@fclairamb fclairamb enabled auto-merge (squash) May 3, 2025 08:58
@fclairamb fclairamb merged commit 6e2547d into fclairamb:main May 4, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants