Fix compatibility with AsyncDisplayKit #12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AsyncDisplayKit was requesting a layout before the collection view had items (or sections). That led to a crash because the `numberOfItems` computed property was querying the collection view for the number of items in non-existent section 0. This fix updates the `numberOfItems` computed property to always return 0 if there aren’t any sections in the collection view.
|
@fdzsergio Looks like CircleCI is failing; is that something you can fix? It says "Please select an OS X plan." |
Current coverage is 100% (diff: 100%)
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes an NSInternalInconsistencyExceptionn that occurs when using SFFocusViewLayout with AsyncDisplayKit. The commit message has more details.