-
-
Notifications
You must be signed in to change notification settings - Fork 84
feat: add custom link to WebFinger's Links fields. #407
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Summary of Changes
Hello @dodok8, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request introduces a new mechanism to allow applications to dynamically add custom links to WebFinger responses. This enhances the flexibility of WebFinger by enabling the inclusion of application-specific or dynamic information within the Links field, ensuring that federated applications can provide richer and more tailored responses.
Highlights
- Custom WebFinger Links: Implemented a WebFingerLinkDispatcher to allow dynamic addition of custom links to WebFinger responses, enhancing the flexibility of the protocol.
- Federation Builder Integration: The new dispatcher is integrated into the FederationBuilder pattern, providing a setWebFingerLinkDispatcher method for easy configuration by applications.
- Middleware Support: The WebFinger handling middleware has been updated to utilize the new dispatcher, ensuring that custom links are correctly included in the final WebFinger response.
- Enhanced Test Coverage: New test cases have been added to validate the functionality of the WebFingerLinkDispatcher, and the MockFederation utility has been extended to support comprehensive testing of this feature.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
5432e6c to
1b29a6e
Compare
|
Warning Gemini encountered an error creating the review. You can try again by commenting |
|
The docs for this pull request have been published: |
77797c8 to
712515f
Compare
f9f794f to
46eb68b
Compare
Co-authored-by: Hong Minhee (洪 民憙) <[email protected]>
Co-authored-by: Hong Minhee (洪 民憙) <[email protected]>
Co-authored-by: Hong Minhee (洪 民憙) <[email protected]>
Co-authored-by: Hong Minhee (洪 民憙) <[email protected]>
46eb68b to
f817af7
Compare
|
The latest push to this pull request has been published to JSR and npm as a pre-release:
|
Summary
Added
setWebFingerLinksDispatcher(dispatcher)to set additional links toLinksof Webfinger.Related Issue
rel= 'http://ostatus.org/schema/1.0/subscribe'andtemplate#119Changes
WebFingerLinksDispatchersupport to the federation builder pattern.WebFingerLinksDispatcherinto the WebFinger request handling flow.MockFederationto supportWebFingerLinksDispatchertestingBenefits
Checklist
deno task test-allon your machine?Additional Notes
Currently, I am working on writing docs. However, unlike
NodeInfo, context aboutWebFingeris split, so I tried to collect it into one chapter first.