Skip to content

Conversation

@dodok8
Copy link
Contributor

@dodok8 dodok8 commented Sep 4, 2025

Summary

Added setWebFingerLinksDispatcher(dispatcher) to set additional links to Links of Webfinger.

Related Issue

Changes

  • Added WebFingerLinksDispatcher support to the federation builder pattern.
  • Integrated WebFingerLinksDispatcher into the WebFinger request handling flow.
  • Updated middleware to support the new dispatcher
  • Added Test
  • Extended MockFederation to support WebFingerLinksDispatcher testing

Benefits

  • Applications can now customize WebFinger responses with dynamic links

Checklist

  • Did you add a changelog entry to the CHANGES.md?
  • Did you write some relevant docs about this change (if it's a new feature)?
  • Did you write a regression test to reproduce the bug (if it's a bug fix)?
  • Did you write some tests for this change (if it's a new feature)?
  • Did you run deno task test-all on your machine?

Additional Notes

Currently, I am working on writing docs. However, unlike NodeInfo, context about WebFinger is split, so I tried to collect it into one chapter first.

@dodok8 dodok8 marked this pull request as draft September 4, 2025 12:41
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Summary of Changes

Hello @dodok8, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces a new mechanism to allow applications to dynamically add custom links to WebFinger responses. This enhances the flexibility of WebFinger by enabling the inclusion of application-specific or dynamic information within the Links field, ensuring that federated applications can provide richer and more tailored responses.

Highlights

  • Custom WebFinger Links: Implemented a WebFingerLinkDispatcher to allow dynamic addition of custom links to WebFinger responses, enhancing the flexibility of the protocol.
  • Federation Builder Integration: The new dispatcher is integrated into the FederationBuilder pattern, providing a setWebFingerLinkDispatcher method for easy configuration by applications.
  • Middleware Support: The WebFinger handling middleware has been updated to utilize the new dispatcher, ensuring that custom links are correctly included in the final WebFinger response.
  • Enhanced Test Coverage: New test cases have been added to validate the functionality of the WebFingerLinkDispatcher, and the MockFederation utility has been extended to support comprehensive testing of this feature.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in issue comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@github-actions github-actions bot added activitypub/interop Interoperability issues component/webfinger WebFinger related type/enhancement Improvements to existing features labels Sep 4, 2025
@dodok8 dodok8 force-pushed the dodok8-custom-webfinger branch from 5432e6c to 1b29a6e Compare September 4, 2025 12:44
@gemini-code-assist
Copy link
Contributor

Warning

Gemini encountered an error creating the review. You can try again by commenting /gemini review.

@github-actions
Copy link
Contributor

github-actions bot commented Sep 4, 2025

The docs for this pull request have been published:

https://aa53c65b.fedify.pages.dev

@dodok8 dodok8 force-pushed the dodok8-custom-webfinger branch from f9f794f to 46eb68b Compare September 5, 2025 01:40
@dodok8 dodok8 force-pushed the dodok8-custom-webfinger branch from 46eb68b to f817af7 Compare September 5, 2025 02:15
@dodok8 dodok8 marked this pull request as ready for review September 5, 2025 06:30
@github-actions
Copy link
Contributor

github-actions bot commented Sep 5, 2025

The latest push to this pull request has been published to JSR and npm as a pre-release:

Package Version JSR npm
@fedify/fedify 1.9.0-pr.407.1544+f591def8 JSR npm
@fedify/cli 1.9.0-pr.407.1544+f591def8 JSR
@fedify/amqp 1.9.0-pr.407.1544+f591def8 JSR npm
@fedify/cfworkers 1.9.0-pr.407.1544+f591def8 JSR npm
@fedify/denokv 1.9.0-pr.407.1544+f591def8 JSR
@fedify/elysia 1.9.0-pr.407.1544+f591def8 npm
@fedify/express 1.9.0-pr.407.1544+f591def8 JSR npm
@fedify/h3 1.9.0-pr.407.1544+f591def8 JSR npm
@fedify/hono 1.9.0-pr.407.1544+f591def8 JSR npm
@fedify/nestjs 1.9.0-pr.407.1544+f591def8 npm
@fedify/next 1.9.0-pr.407.1544+f591def8 npm
@fedify/postgres 1.9.0-pr.407.1544+f591def8 JSR npm
@fedify/redis 1.9.0-pr.407.1544+f591def8 JSR npm
@fedify/sqlite 1.9.0-pr.407.1544+f591def8 JSR npm
@fedify/sveltekit 1.9.0-pr.407.1544+f591def8 JSR npm
@fedify/testing 1.9.0-pr.407.1544+f591def8 JSR npm

@dahlia dahlia merged commit 46a9a06 into fedify-dev:main Sep 7, 2025
10 checks passed
@dahlia dahlia modified the milestones: Fedify 2.0, Fedify 1.9 Sep 10, 2025
@dodok8 dodok8 deleted the dodok8-custom-webfinger branch September 11, 2025 11:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

activitypub/interop Interoperability issues component/webfinger WebFinger related type/enhancement Improvements to existing features

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Webfinger in Fedify should support Mastodon's special rel= 'http://ostatus.org/schema/1.0/subscribe' and template

2 participants