Repository navigation
feat(bloc): add option to specify events and states in bloc brick - #4909
Open
GhagSagar23 wants to merge 1 commit into
Open
GhagSagar23 wants to merge 1 commit into
GhagSagar23 wants to merge 1 commit into
Conversation
Author
|
Friendly ping @felangel — ready for review whenever you get a chance. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
mason make blocto optionally specify custom events and stateson<Event>handlers with private methodsHow it works
The
pre_gen.darthook usescontext.logger.confirm()andcontext.logger.prompt()to collect event/state names in a loop. Names are passed as lists to mustache templates viacontext.vars.Example (
mason make bloc --name cart, style: basic, events: CartLoading/CartLoaded/CartError):Test plan
dart analyze bricks/bloc/hooks/— cleandart format bricks/bloc/hooks/— cleanmason make blocwith no events/states → identical to current outputmason make blocwith events + states → generates subclasses and handlersCloses #3487