Fix ConnectionStrategy.make_connection return type #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
p7g
force-pushed
the
fix-connectionstrategy-types
branch
from
a89779e
to
b134d0a
Compare
p7g
force-pushed
the
fix-connectionstrategy-types
branch
from
41fc707
to
05dbdd5
Compare
p7g
force-pushed
the
fix-connectionstrategy-types
branch
from
05dbdd5
to
3a8fde7
Compare
p7g
force-pushed
the
fix-connectionstrategy-types
branch
from
e6b98a0
to
d60e6a6
Compare
sciyoshi
approved these changes
May 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #8
Did this work ages ago and apparently forgot to merge it
Plus fixes for CI