Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add types for prosemirror.model #233

Merged
merged 41 commits into from
Nov 16, 2023
Merged

Add types for prosemirror.model #233

merged 41 commits into from
Nov 16, 2023

Commits on Oct 11, 2023

  1. Add typing for prosemirror.utils and add JSON alias

    @sciyoshi
    sciyoshi committed Oct 11, 2023
    Configuration menu
    Copy the full SHA
    ad48c5b View commit details
    Browse the repository at this point in the history

  2. Add typing for prosemirror.model.comparedeep

    @sciyoshi
    sciyoshi committed Oct 11, 2023
    Configuration menu
    Copy the full SHA
    2d7411c View commit details
    Browse the repository at this point in the history

  3. Typing for prosemirror.model.content

    @sciyoshi
    sciyoshi committed Oct 11, 2023
    Configuration menu
    Copy the full SHA
    927409b View commit details
    Browse the repository at this point in the history

  4. Typing for prosemirror.model.diff

    @sciyoshi
    sciyoshi committed Oct 11, 2023
    Configuration menu
    Copy the full SHA
    7380bae View commit details
    Browse the repository at this point in the history

  5. Typing for schema + fixes uncovered

    @sciyoshi
    sciyoshi committed Oct 11, 2023
    Configuration menu
    Copy the full SHA
    f9a7e30 View commit details
    Browse the repository at this point in the history

  6. Typing for prosemirror.model.fragment

    @sciyoshi
    sciyoshi committed Oct 11, 2023
    Configuration menu
    Copy the full SHA
    a1160cf View commit details
    Browse the repository at this point in the history

  7. Add typings for node

    @sciyoshi
    sciyoshi committed Oct 11, 2023
    Configuration menu
    Copy the full SHA
    6426a80 View commit details
    Browse the repository at this point in the history

  8. Finish typing for node

    @sciyoshi
    sciyoshi committed Oct 11, 2023
    Configuration menu
    Copy the full SHA
    690f7d5 View commit details
    Browse the repository at this point in the history

  9. Typing for prosemirror.model.replace

    @sciyoshi
    sciyoshi committed Oct 11, 2023
    Configuration menu
    Copy the full SHA
    662170e View commit details
    Browse the repository at this point in the history

  10. Typing for prosemirror.model.mark

    @sciyoshi
    sciyoshi committed Oct 11, 2023
    Configuration menu
    Copy the full SHA
    54614bc View commit details
    Browse the repository at this point in the history

  11. typing for to_dom

    @sciyoshi
    sciyoshi committed Oct 11, 2023
    Configuration menu
    Copy the full SHA
    63caf86 View commit details
    Browse the repository at this point in the history

  12. Fix strict issues

    @sciyoshi
    sciyoshi committed Oct 11, 2023
    Configuration menu
    Copy the full SHA
    aa20294 View commit details
    Browse the repository at this point in the history

  13. Fix typing in tests

    @sciyoshi
    sciyoshi committed Oct 11, 2023
    Configuration menu
    Copy the full SHA
    4fbf213 View commit details
    Browse the repository at this point in the history

  14. Additional typing fixes

    @sciyoshi
    sciyoshi committed Oct 11, 2023
    Configuration menu
    Copy the full SHA
    455624a View commit details
    Browse the repository at this point in the history

  15. A few typing and mypyc fixes, remove dataclass

    @sciyoshi
    sciyoshi committed Oct 11, 2023
    Configuration menu
    Copy the full SHA
    fcdb113 View commit details
    Browse the repository at this point in the history

  16. Address comments

    @sciyoshi
    sciyoshi committed Oct 11, 2023
    Configuration menu
    Copy the full SHA
    5101e22 View commit details
    Browse the repository at this point in the history

  17. Fix on python 3.8

    @sciyoshi
    sciyoshi committed Oct 11, 2023
    Configuration menu
    Copy the full SHA
    e4d3a9d View commit details
    Browse the repository at this point in the history

  18. Fix attribute computation

    @sciyoshi
    sciyoshi committed Oct 11, 2023
    Configuration menu
    Copy the full SHA
    5f5ce01 View commit details
    Browse the repository at this point in the history

  19. Mutable JSON

    @sciyoshi
    sciyoshi committed Oct 11, 2023
    Configuration menu
    Copy the full SHA
    c61cf39 View commit details
    Browse the repository at this point in the history

Commits on Nov 13, 2023

  1. Upgrading to mypy 1.7.0. Making mypy strict for all modules.

    @ernesto-at-fellow
    ernesto-at-fellow committed Nov 13, 2023
    Configuration menu
    Copy the full SHA
    0f3b18e View commit details
    Browse the repository at this point in the history

  2. Removing mutable json types. Creating new immutable instances instead… 

    … of mutating existing ones.
    @ernesto-at-fellow
    ernesto-at-fellow committed Nov 13, 2023
    Configuration menu
    Copy the full SHA
    f1bda00 View commit details
    Browse the repository at this point in the history

  3. Using the built-in types for type annotations instead of the ones fro… 

    …m the typing module if possible.
    @ernesto-at-fellow
    ernesto-at-fellow committed Nov 13, 2023
    Configuration menu
    Copy the full SHA
    47ab753 View commit details
    Browse the repository at this point in the history

  4. Adding types to the transform module. Creating the Mappable abstract … 

    …class (just like in the original prosemirror repo).
    @ernesto-at-fellow
    ernesto-at-fellow committed Nov 13, 2023
    Configuration menu
    Copy the full SHA
    4c08bf4 View commit details
    Browse the repository at this point in the history

  5. Remove leftover debugging comment.

    @ernesto-at-fellow
    ernesto-at-fellow committed Nov 13, 2023
    Configuration menu
    Copy the full SHA
    2830ca9 View commit details
    Browse the repository at this point in the history

Commits on Nov 14, 2023

  1. Using generic types for most uses of Schema, just like in the origina… 

    …l repo.
    @ernesto-at-fellow
    ernesto-at-fellow committed Nov 14, 2023
    Configuration menu
    Copy the full SHA
    5c41951 View commit details
    Browse the repository at this point in the history

  2. Adding missing import of Attrs.

    @ernesto-at-fellow
    ernesto-at-fellow committed Nov 14, 2023
    Configuration menu
    Copy the full SHA
    7c2a85a View commit details
    Browse the repository at this point in the history

  3. Reverting changes to Mark.to_json that broke tests.

    @ernesto-at-fellow
    ernesto-at-fellow committed Nov 14, 2023
    Configuration menu
    Copy the full SHA
    e919932 View commit details
    Browse the repository at this point in the history

  4. Restoring attr step.

    @ernesto-at-fellow
    ernesto-at-fellow committed Nov 14, 2023
    Configuration menu
    Copy the full SHA
    1ca91b9 View commit details
    Browse the repository at this point in the history

  5. Fixing regression on Transform.replace_range.

    @ernesto-at-fellow
    ernesto-at-fellow committed Nov 14, 2023
    Configuration menu
    Copy the full SHA
    ef9feb6 View commit details
    Browse the repository at this point in the history

Commits on Nov 15, 2023

  1. Add py.typed

    @sciyoshi
    sciyoshi committed Nov 15, 2023
    Configuration menu
    Copy the full SHA
    3edecdf View commit details
    Browse the repository at this point in the history

  2. Merge remote-tracking branch 'origin/main' into typing-2

    @sciyoshi
    sciyoshi committed Nov 15, 2023
    Configuration menu
    Copy the full SHA
    5f51e6a View commit details
    Browse the repository at this point in the history

  3. Typing fixes after merging main

    @sciyoshi
    sciyoshi committed Nov 15, 2023
    Configuration menu
    Copy the full SHA
    e45c7eb View commit details
    Browse the repository at this point in the history

  4. Fix tests + typing in transform replace_range

    @sciyoshi
    sciyoshi committed Nov 15, 2023
    Configuration menu
    Copy the full SHA
    81f8232 View commit details
    Browse the repository at this point in the history

  5. Updating some type annotations to match the original repos.

    @ernesto-at-fellow
    ernesto-at-fellow committed Nov 15, 2023
    Configuration menu
    Copy the full SHA
    1539783 View commit details
    Browse the repository at this point in the history

Commits on Nov 16, 2023

  1. Reverting the type annotation syntax to be valid for Python 3.9.

    @ernesto-at-fellow
    ernesto-at-fellow committed Nov 16, 2023
    Configuration menu
    Copy the full SHA
    caa206d View commit details
    Browse the repository at this point in the history

  2. Removing the mypy check from "tests" since there seems to be no way t… 

    …o override the strict option for some modules (python/mypy#11401).
    @ernesto-at-fellow
    ernesto-at-fellow committed Nov 16, 2023
    Configuration menu
    Copy the full SHA
    0e6c2e3 View commit details
    Browse the repository at this point in the history

  3. Minor changes to types are reviewing the original TS repos.

    @ernesto-at-fellow
    ernesto-at-fellow committed Nov 16, 2023
    Configuration menu
    Copy the full SHA
    f467c25 View commit details
    Browse the repository at this point in the history

  4. More minor fixes related to type annotations syntax and Python 3.9.

    @ernesto-at-fellow
    ernesto-at-fellow committed Nov 16, 2023
    Configuration menu
    Copy the full SHA
    be372f1 View commit details
    Browse the repository at this point in the history

  5. Making type annotations compatible with Python 3.8.

    @ernesto-at-fellow
    ernesto-at-fellow committed Nov 16, 2023
    Configuration menu
    Copy the full SHA
    f1fad36 View commit details
    Browse the repository at this point in the history

  6. Using Callable from Typing for Python 3.8 compatibility reasons.

    @ernesto-at-fellow
    ernesto-at-fellow committed Nov 16, 2023
    Configuration menu
    Copy the full SHA
    d12715e View commit details
    Browse the repository at this point in the history

  7. Minor version bump due to the mypy related changes.

    @ernesto-at-fellow
    ernesto-at-fellow committed Nov 16, 2023
    Configuration menu
    Copy the full SHA
    b061e0e View commit details
    Browse the repository at this point in the history