Default requestParams

[GuillaumeBolo]

Some simple code for default requestParams without set/get function
For example "with", "replies" and new futur param if necessary

$sc = new MyUserConsumer( OAUTH_TOKEN, OAUTH_SECRET, Phirehose::METHOD_USER );
$sc->setRequestParam( 'with', 'user' );
$sc->consume();

HTH
Guillaume

[juuga]

Great PR Guillaume, I hope this is merged.

[fennb]

I like this, and it seems low-risk. Mind you, I feel like ultimately the library should support the "real" parameters, but no matter.

@DarrenCook - thoughts?

[juuga]

Personally, I would be happy with just a setWith('user') if only "real" parameters are hoped for, but as Guillaume said, this PR would be future proof.

[DarrenCook]

No strong thoughts; though if "with" is the only parameter that is missed currently, a setWith() makes more sense?

If sticking with this, maybe call it setDefaultRequestParams(), so people are not so surprised when their setting is ignored. OR, change the following lines to only set things if a value was not set already. E.g. change:
if($this->lang) {
$requestParams['language'] = $this->lang;
}

to:
if($this->lang && ! array_key_exists('language',$requestParams)) {
$requestParams['language'] = $this->lang;
}

And the same for the others.

[GuillaumeBolo]

@DarrenCook : maybe call it setDefaultRequestParams()

Of course, it was i wanted to mean.
Setter is a better way, but i especially wanted to have a generic solution for futur update of Twitter API

GB

[juuga]

@fennb @DarrenCook any chance of this being merged, or implemented in the way Darren suggested?