Support local certificates and HTTP proxies #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
mariovisic
commented
Nov 5, 2025
mariovisic
commented
- Allow specifying the local certificate to check and the CA bundle rather than looking up the certificates via URL.
- Support providing a proxy host and port
- Allow specifying the local certificate to check and the CA bundle rather than looking up the certificates via URL. - Support providing a proxy host and port
lucasteligioridis
approved these changes
Nov 5, 2025
lucasteligioridis
left a comment
lucasteligioridis
left a comment
There was a problem hiding this comment.
Very nice 👏🏼
Would it be hard to also support the ca_bundle_path being a value like client_cert thats read? i.e. from a header or environment variable, rather than a file?
lucasteligioridis
approved these changes
Nov 5, 2025
Collaborator
Author
|
thanks @lucasteligioridis patched in 1fbdcb6 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.