#61 Time zone converter added - #425
Conversation
|
Hello @ferraridamiano , could you please review and approve? Thanks! |
|
Hello @mareksagan Thank you for this PR. Sorry but in this period I am quite busy. I will review it as soon as I can. Don't expect anything in the next 10 days or so |
ferraridamiano
left a comment
ferraridamiano
left a comment
There was a problem hiding this comment.
Hi @mareksagan and thanks for your contribution. I left few comments that should be addressed. Overall it seems quite good
There was a problem hiding this comment.
I suggest you to use an icon similar to this. Otherwise it's not clear
There was a problem hiding this comment.
Agreed, the proposed looks like a basketball to me, this would be much clearer visually.
| _ => switch (propertyx) { | ||
| PROPERTYX.timezone => TextInputType.datetime, |
| // Reset to default order when units are missing or out of order | ||
| if (storedOrder.length != defaultOrder.length || | ||
| !listEquals(storedOrder, defaultOrder)) { | ||
| storedOrder = defaultOrder.toList(); |
| "utcMinus12": "Baker Island (UTC-12)", | ||
| "utcMinus11": "American Samoa (UTC-11)", | ||
| "utcMinus10": "Hawaii (UTC-10)", | ||
| "utcMinus9_30": "Marquesas Islands (UTC-09:30)", | ||
| "utcMinus9": "Alaska (UTC-09)", | ||
| "utcMinus8": "Pacific Time (UTC-08)", | ||
| "utcMinus7": "Mountain Time (UTC-07)", | ||
| "utcMinus6": "Central Time (UTC-06)", | ||
| "utcMinus5": "Eastern Time (UTC-05)", | ||
| "utcMinus4": "Atlantic Time (UTC-04)", | ||
| "utcMinus3_30": "Newfoundland (UTC-03:30)", | ||
| "utcMinus3": "Argentina (UTC-03)", | ||
| "utcMinus2": "South Georgia (UTC-02)", | ||
| "utcMinus1": "Azores (UTC-01)", | ||
| "utc0": "United Kingdom (UTC+0)", | ||
| "utcPlus1": "Central Europe (UTC+01)", | ||
| "utcPlus2": "Eastern Europe (UTC+02)", | ||
| "utcPlus3": "Moscow (UTC+03)", | ||
| "utcPlus3_30": "Iran (UTC+03:30)", | ||
| "utcPlus4": "UAE (UTC+04)", | ||
| "utcPlus4_30": "Afghanistan (UTC+04:30)", | ||
| "utcPlus5": "Pakistan (UTC+05)", | ||
| "utcPlus5_30": "India (UTC+05:30)", | ||
| "utcPlus5_45": "Nepal (UTC+05:45)", | ||
| "utcPlus6": "Bangladesh (UTC+06)", | ||
| "utcPlus6_30": "Myanmar (UTC+06:30)", | ||
| "utcPlus7": "Thailand (UTC+07)", | ||
| "utcPlus8": "China (UTC+08)", | ||
| "utcPlus8_45": "Eucla (UTC+08:45)", | ||
| "utcPlus9": "Japan (UTC+09)", | ||
| "utcPlus9_30": "Central Australia (UTC+09:30)", | ||
| "utcPlus10": "Eastern Australia (UTC+10)", | ||
| "utcPlus10_30": "Lord Howe Island (UTC+10:30)", | ||
| "utcPlus11": "Solomon Islands (UTC+11)", | ||
| "utcPlus12": "New Zealand (UTC+12)", | ||
| "utcPlus12_45": "Chatham Islands (UTC+12:45)", | ||
| "utcPlus13": "Tonga (UTC+13)", | ||
| "utcPlus14": "Line Islands (UTC+14)", | ||
|
|
There was a problem hiding this comment.
You should extend this to other languages with a note for the translators. See what I have done for other untranslated strings
|
Another very important thing is to use the units_converter package. Please open there a PR and then let's integrate the required changes in this PR |
3 participants
#61
List of pseudo-timezones used for conversions:
UTC Negative (West)
• UTC-12
• UTC-11
• UTC-10
• UTC-09:30
• UTC-09
• UTC-08
• UTC-07
• UTC-06
• UTC-05
• UTC-04
• UTC-03:30
• UTC-03
• UTC-02
• UTC-01
UTC Zero
• UTC+0
UTC Positive (East)
• UTC+01
• UTC+02
• UTC+03
• UTC+03:30
• UTC+04
• UTC+04:30
• UTC+05
• UTC+05:30
• UTC+05:45
• UTC+06
• UTC+06:30
• UTC+07
• UTC+08
• UTC+08:45
• UTC+09
• UTC+09:30
• UTC+10
• UTC+10:30
• UTC+11
• UTC+12
• UTC+12:45
• UTC+13
• UTC+14