Gate debug logging with static DEBUG_ENABLED flag#303
Merged
Conversation
Add CompilerOptions.DEBUG_ENABLED static boolean that is set when --debug or -D flags are parsed. All logDebug() calls are now guarded with a one-line if statement check for fast short-circuit evaluation when debugging is disabled. This improves performance by avoiding method call overhead and string concatenation for debug messages when not in debug mode. Generated with [Devin](https://cli.devin.ai/docs) Co-Authored-By: Devin <noreply@cognition.ai>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
CompilerOptions.DEBUG_ENABLEDstatic boolean flag--debugor-DCLI arguments are parsedlogDebug()calls with one-lineif (CompilerOptions.DEBUG_ENABLED)checksPerformance Improvement
When debugging is disabled (the common case), this avoids:
logDebug()invocationlogDebug()methodThe JIT compiler can now short-circuit these calls at the call site level.
Test Plan
./gradlew build)./gradlew test)--debugflag--debugflagGenerated with Devin