Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: Ignore tests that requires dot if the executable is not present #519

Merged
merged 1 commit into from
Jan 26, 2025

Conversation

fgmacedo
Copy link
Owner

@fgmacedo fgmacedo commented Jan 26, 2025

Using a new notebook, noted that the first run of the tests failed because the graphviz was missing.

Turned these tests optional and skipped if the dot executable is not present.

Copy link

codecov bot commented Jan 26, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (9954890) to head (aace46a).
Report is 1 commits behind head on develop.

Additional details and impacted files
@@            Coverage Diff            @@
##           develop      #519   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           25        25           
  Lines         1631      1631           
  Branches       257       257           
=========================================
  Hits          1631      1631           
Flag Coverage Δ
unittests 100.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@fgmacedo fgmacedo merged commit bdb4fbd into develop Jan 26, 2025
14 of 15 checks passed
@fgmacedo fgmacedo deleted the macedo/ignore-dot-tests-if-not-installed branch January 26, 2025 18:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant