adding model and dataset flags to harness#18
Open
stamcenter wants to merge 5 commits intofhe-benchmarking:mainfrom
Open
adding model and dataset flags to harness#18stamcenter wants to merge 5 commits intofhe-benchmarking:mainfrom
stamcenter wants to merge 5 commits intofhe-benchmarking:mainfrom
Conversation
added 5 commits
March 16, 2026 17:42
…r multiple models
stamcenter
changed the title
Contributor
andreea-alexandru
left a comment
andreea-alexandru
left a comment
There was a problem hiding this comment.
Looks good to me, I just left a few minor comments.
| labels_file=LABELS_PATH, | ||
| num_samples=num_samples, | ||
| seed=seed) | ||
| if dataset_name == "mnist": |
Contributor
There was a problem hiding this comment.
Turn this into a switch statement in preparation for multiple models?
| exec_dir = params.rootdir/ ("submission_remote" if remote_be else "submission") | ||
| exec_dir = params.rootdir/ ("submission_remote" if remote_be else "submissions") | ||
|
|
||
| # check whether the exec_dir contains a subdirector equals to the model name. |
| @@ -28,20 +28,26 @@ def main(): | |||
|
|
|||
Contributor
There was a problem hiding this comment.
Update the README to reflect the new python3 harness/run_submission.py -h.
| "total_latency_ms": round(sum(_timestamps.values()), 4), | ||
| "per_stage": _timestampsStr, | ||
| "bandwidth": _bandwidth, | ||
| "mnist_model_quality" : _model_quality, |
Contributor
There was a problem hiding this comment.
Just "model_quality"?
| #include <chrono> | ||
| #include <fstream> | ||
| #include <iomanip> | ||
| #include <nlohmann/json.hpp> |
Contributor
There was a problem hiding this comment.
It doesn't seem like something relevant changed in build_task.sh, but now I get a compilation error here
fatal error: nlohmann/json.hpp: No such file or directory
24 | #include <nlohmann/json.hpp>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request extends the harness interface by introducing two new parameters:
--model
--dataset
These parameters allow the harness to dynamically select the model and dataset used during submission execution. It also moved the fault mlp model provided in the submission folder into the submissions folder for testing.