invalid response on cancel fixes #381#382
Open
denisacostaq wants to merge 10 commits intofibercrypto:developfrom
Open
invalid response on cancel fixes #381#382denisacostaq wants to merge 10 commits intofibercrypto:developfrom
denisacostaq wants to merge 10 commits intofibercrypto:developfrom
Conversation
added 5 commits
January 15, 2020 17:20
Change pin should return canceled when a cancel command is recived not a pin mismatch ref fibercrypto#381
…n_t381_invald_response_on_cancel ref fibercrypto#381
stdevAlDen
added
bootloader
olemis
requested changes
Mar 4, 2020
Collaborator
olemis
left a comment
olemis
left a comment
There was a problem hiding this comment.
Firmware test suite needs to cover the case of PIN op cancellation
added 2 commits
March 4, 2020 18:43
…m:simelo/skywallet-mcu into stdevAlDen_t381_invald_response_on_cancel ref fibercrypto#381
olemis
changed the title
stdevAlDen
force-pushed
the
stdevAlDen_t381_invald_response_on_cancel
branch
3 times, most recently
from
c762bad to
27e99a4
Compare
stdevAlDen
force-pushed
the
stdevAlDen_t381_invald_response_on_cancel
branch
from
27e99a4 to
5f32cc5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #381
Changes:
Does this change need to mentioned in CHANGELOG.md?
no
Requires testing
yes