Use a context manager for yaspin

Avoids tests from blocking
fief-dev · Jun 3, 2024 · 1bdb8d4 · 1bdb8d4
1 parent 9b78893
commit 1bdb8d4
Showing 1 changed file with 28 additions and 30 deletions.
diff --git a/fief_client/integrations/cli.py b/fief_client/integrations/cli.py
@@ -234,38 +234,36 @@ def authorize(
         )
         webbrowser.open(authorization_url)
 
-        spinner = yaspin(
+        with yaspin(
             text="Please complete authentication in your browser.",
             spinner=Spinners.dots,
-        )
-        spinner.start()
-
-        code_queue: queue.Queue[str] = queue.Queue()
-        server = CallbackHTTPServer(
-            server_address,
-            functools.partial(
-                CallbackHTTPRequestHandler,
-                queue=code_queue,
-                render_success_page=self.render_success_page,
-                render_error_page=self.render_error_page,
-            ),
-        )
-
-        server.serve_forever()
-
-        try:
-            code = code_queue.get(block=False)
-        except queue.Empty as e:
-            raise FiefAuthAuthorizationCodeMissingError() from e
-
-        spinner.text = "Getting a token..."
-
-        tokens, userinfo = self.client.auth_callback(
-            code, redirect_uri, code_verifier=code_verifier
-        )
-        self._save_credentials(tokens, userinfo)
-
-        spinner.ok("Successfully authenticated")
+        ) as spinner:
+            code_queue: queue.Queue[str] = queue.Queue()
+            server = CallbackHTTPServer(
+                server_address,
+                functools.partial(
+                    CallbackHTTPRequestHandler,
+                    queue=code_queue,
+                    render_success_page=self.render_success_page,
+                    render_error_page=self.render_error_page,
+                ),
+            )
+
+            server.serve_forever()
+
+            try:
+                code = code_queue.get(block=False)
+            except queue.Empty as e:
+                raise FiefAuthAuthorizationCodeMissingError() from e
+
+            spinner.text = "Getting a token..."
+
+            tokens, userinfo = self.client.auth_callback(
+                code, redirect_uri, code_verifier=code_verifier
+            )
+            self._save_credentials(tokens, userinfo)
+
+            spinner.ok("Successfully authenticated")
 
         return tokens, userinfo