-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: replace halo with yaspin #19
fix: replace halo with yaspin #19
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, looks good 🙏 The only change needed is to move the dependency in the right group (see comment above).
pyproject.toml
Outdated
@@ -46,6 +46,7 @@ dependencies = [ | |||
"pytest-mock", | |||
"respx", | |||
"ruff", | |||
"yaspin", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The dependency should be in the cli
group and replace halo
(line 116).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
got it, should have searched for halo in the pyproject before pushing. Thank you!
Had an error in testing, I have all tests passing locally, hoping the last push gets us there |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #19 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 7 7
Lines 689 670 -19
=========================================
- Hits 689 670 -19 ☔ View full report in Codecov by Sentry. |
Can you give me rights to edit the PR (Allow edits from maintainer on the right)? I've a fix for failing tests. |
d7905fc
to
a8ae24b
Compare
We looked for a solid 20 minutes and can't figure out where github moved this option 😅 Maybe it's some configuration we need to update, but github docs no help there either |
Ok! Editing PR from forks is always a nightmare 😅 I'll merge it as it and apply my changes on the main branch. Thank you for the work on this 🙏 |
Description
Fixes #18
This is a change to fief-python
Halo is used to produce the spinner in the cli and IPython. This causes an error, and since halo is no longer maintained, we have replaced halo with yaspin