Skip to content

refactor: align add command with clean CLI separation pattern #273

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
SgtPooki merged 2 commits into from
Dec 4, 2025
Merged

refactor: align add command with clean CLI separation pattern #273

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c650866
refactor: clean separation pattern for add cli command
entuziaz Nov 27, 2025
439a6c1
fix: little changes
entuziaz Dec 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions src/add/add.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,7 +86,6 @@ export async function runAdd(options: AddOptions): Promise<AddResult> {
const proceed = await warnAboutCDNPricingLimitations()
if (!proceed) {
cancel('Add cancelled')
process.exitCode = 1
throw new Error('CDN pricing limitations warning cancelled')
}
}
Expand All @@ -101,7 +100,7 @@ export async function runAdd(options: AddOptions): Promise<AddResult> {
if (!pathValidation.exists || !pathValidation.stats) {
spinner.stop(`${pc.red('✗')} ${pathValidation.error}`)
cancel('Add cancelled')
process.exit(1)
throw new Error(pathValidation.error)
}

const pathStat = pathValidation.stats
Expand Down Expand Up @@ -247,6 +246,6 @@ export async function runAdd(options: AddOptions): Promise<AddResult> {
}

cancel('Add failed')
process.exit(1)
throw error
}
}
3 changes: 1 addition & 2 deletions src/commands/add.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,8 +30,7 @@ export const addCommand = new Command('add')
}

await runAdd(addOptions)
} catch (error) {
console.error('Add failed:', error instanceof Error ? error.message : error)
} catch (_error) {
Copy link
Collaborator

@SgtPooki SgtPooki Dec 1, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
} catch (_error) {
} catch {

process.exit(1)
}
})
Expand Down
24 changes: 9 additions & 15 deletions src/test/unit/add.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -233,51 +233,45 @@ describe('Add Command', () => {
})

it('should reject when file does not exist', async () => {
const mockExit = vi.spyOn(process, 'exit').mockImplementation(() => {
throw new Error('process.exit called')
})
const mockExit = vi.spyOn(process, 'exit')

await expect(
runAdd({
filePath: '/non/existent/file.txt',
privateKey: 'test-key',
})
).rejects.toThrow('process.exit called')
).rejects.toThrow('Path not found')

expect(mockExit).toHaveBeenCalledWith(1)
expect(mockExit).not.toHaveBeenCalled()
mockExit.mockRestore()
})

it('should reject when private key is missing', async () => {
const mockExit = vi.spyOn(process, 'exit').mockImplementation(() => {
throw new Error('process.exit called')
})
const mockExit = vi.spyOn(process, 'exit')

await expect(
runAdd({
filePath: testFile,
// No private key
})
).rejects.toThrow('process.exit called')
).rejects.toThrow()

expect(mockExit).toHaveBeenCalledWith(1)
expect(mockExit).not.toHaveBeenCalled()
mockExit.mockRestore()
})

it('should reject --bare flag with directories', async () => {
const mockExit = vi.spyOn(process, 'exit').mockImplementation(() => {
throw new Error('process.exit called')
})
const mockExit = vi.spyOn(process, 'exit')

await expect(
runAdd({
filePath: testDir, // Directory
privateKey: 'test-key',
bare: true, // --bare flag should not work with directories
})
).rejects.toThrow('process.exit called')
).rejects.toThrow('--bare flag is not supported for directories')

expect(mockExit).toHaveBeenCalledWith(1)
expect(mockExit).not.toHaveBeenCalled()
mockExit.mockRestore()
})
})
Expand Down
Loading