fix(payments): depend on squid-evm-funding from npm - #667
Closed
SgtPooki wants to merge 21 commits into
Closed
Conversation
FilOzzy
added
team/filecoin-pin
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Builds on #637 (its commits are included unchanged) and adds one commit switching the Squid dependency from
github:FilOzone/squid-evm-funding#v0.1.0to@filecoin-project/squid-evm-funding@^0.1.7from npm. The git dependency was pinned to v0.1.0, which predates the browser fetch fix (FilOzone/squid-evm-funding#19) and the status-polling fix (FilOzone/squid-evm-funding#20); 0.1.7 is the current release, published with provenance through the repo's release workflow.The swap also removes the
onlyBuiltDependenciesentry for the package (the npm tarball ships prebuiltdist/, so no install-time build is needed) and adds the package tominimumReleaseAgeExclude, since the workspace's 7-day cooldown would otherwise reject fresh releases of this first-party dependency. Imports and the test mock move to the scoped name.If #637 lands first, this reduces to the single swap commit; alternatively that commit (18752d3) can be cherry-picked into #637 directly.