Skip to content

fix: bug in importing f3 snapshot #1045

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

hanabi1224
Copy link
Contributor

@hanabi1224 hanabi1224 commented Aug 1, 2025

This PR fixes a bug in F3 snapshot importing to fully read the certificate bytes. @Kubuxu please take a look.

@github-project-automation github-project-automation bot moved this to Todo in F3 Aug 1, 2025
@hanabi1224 hanabi1224 marked this pull request as ready for review August 1, 2025 09:19
Copy link

codecov bot commented Aug 1, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 64.62%. Comparing base (9288fba) to head (8e7fe46).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1045      +/-   ##
==========================================
- Coverage   64.77%   64.62%   -0.16%     
==========================================
  Files          81       81              
  Lines        9896     9896              
==========================================
- Hits         6410     6395      -15     
- Misses       2961     2976      +15     
  Partials      525      525              

see 4 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@hanabi1224 hanabi1224 closed this Aug 1, 2025
@github-project-automation github-project-automation bot moved this from Todo to Done in F3 Aug 1, 2025
@hanabi1224 hanabi1224 deleted the f3-snap-import-bug branch August 1, 2025 12:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

1 participant