fix(survey): Check for nil PeerID before deref - #1120
Open
placer14 wants to merge 1 commit into
Open
Conversation
Contributor
Author
|
I'm unsure why the API would return a |
birdychang
reviewed
Jan 30, 2023
placer14
force-pushed
the
mg/fix/1119-minerinfo-deref-nil
branch
from
January 30, 2023 03:41
4f951f2 to
be146e2
Compare
placer14
force-pushed
the
mg/fix/1119-minerinfo-deref-nil
branch
from
January 30, 2023 03:43
be146e2 to
06a37b0
Compare
frrist
reviewed
Jan 30, 2023
Comment on lines
149
to
-151
| var peerID string | ||
| if minerInfo.PeerId != nil { | ||
| peerID = minerInfo.PeerId.String() |
Member
There was a problem hiding this comment.
I think this would be more clear if this check were moved into getMinerAddrInfo. If the peerID is nil that method can just return and log an error. What do you think @placer14?
frrist
approved these changes
Feb 3, 2023
frrist
left a comment
frrist
left a comment
Member
There was a problem hiding this comment.
Looks good, please address feedback and then merge
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Check for nil
minerinfo.PeerIdbefore deref.fixes #1119