Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(shed): miner locked-vested, and miner list-vested <miner> #12828

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

rvagg
Copy link
Member

@rvagg rvagg commented Jan 14, 2025

Ref: filecoin-project/builtin-actors#1594

Current output:

Scanning actors (looking for v24 miners [bafk2bzacecnl2hqe3nozwo7al7kdznqgdrv2hbbbmpcbcwzh3yl4trog433hc] at epoch 4616980)............................................................................................................................................................................................................................................................................................................................................
Total actors: 3320119
Total miners: 686515
Miners with locked funds: 2073
Total locked funds: 355780.058629719966731966 FIL

@rvagg rvagg added the skip/changelog This change does not require CHANGELOG.md update label Jan 14, 2025
@rvagg rvagg requested a review from ZenGround0 January 14, 2025 00:56
@rvagg
Copy link
Member Author

rvagg commented Jan 14, 2025

@ZenGround0 this is probably overcounting because it's comparing to now but the unlocking only happens on deadline tick. Maybe it should count from WPoStProvingPeriod less than now?

@rvagg
Copy link
Member Author

rvagg commented Jan 14, 2025

If I do that, the number of miners reduces but the total FIL is still large, which makes sense since we're just discounting funds that are about to vest:

Total actors: 3320124
Total miners: 686518
Miners with locked funds: 1530
Total locked funds: 342826.386784283280495497 FIL

Copy link
Contributor

@ZenGround0 ZenGround0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be useful to have an additional command that dumps the vesting table of a given miner if you're in the mood to add that here. But either way it will now be easy to build that with this as an example.

@rvagg rvagg force-pushed the rvagg/locked-funds branch from 09b9e6e to 2badc3f Compare January 14, 2025 03:17
@rvagg rvagg changed the title feat(shed): lotus-shed miner locked-vested to find erroneously locked funds feat(shed): miner locked-vested, and miner list-vested <miner> Jan 14, 2025
@rvagg rvagg force-pushed the rvagg/locked-funds branch from 2badc3f to a62be27 Compare January 14, 2025 03:20
@rvagg
Copy link
Member Author

rvagg commented Jan 14, 2025

@ZenGround0 good idea, done in this PR (change title to match). I also put a "stale epoch" of now minus one deadline, which I think matches how cron works—if it hasn't cleared by then, then it's probably not going to clear. Can you have a look at this logic? Maybe I should -1 from this too?

Total actors: 3320186
Total miners: 2026
Miners with locked vested funds: 2026
Total locked vested funds: 355059.650786527951408884 FIL

It can also list miners and the miners in this list and the amount locked. The largest is f01825045 with 11797, and he's relatively old, from 3956678 to 4463558 where it stops.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip/changelog This change does not require CHANGELOG.md update
Projects
Status: ✔️ Approved by reviewer
Development

Successfully merging this pull request may close these issues.

2 participants