Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update ipld-core and serde_ipld_dagcbor #2104

Merged
merged 1 commit into from
Feb 13, 2025
Merged

Conversation

rvagg
Copy link
Member

@rvagg rvagg commented Feb 13, 2025

Adds support for default fields by being less strict up-front when decoding maps and lists and allowing the visitors to determine what/how to consume the tokens.

I had a bit of trouble using cargo commands to make this happen, particularly to get ipld/encoding/Cargo.toml updated, so I ended up just bumping the numbers manually and doing cargo build to get Cargo.lock to update. So I'd like to know what the proper way would be to do this.

Adds support for default fields by being less strict up-front when decoding
maps and lists and allowing the visitors to determine what/how to consume
the tokens.
@rvagg rvagg requested a review from Stebalien February 13, 2025 06:42
@codecov-commenter
Copy link

codecov-commenter commented Feb 13, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.59%. Comparing base (525faea) to head (3357e3f).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2104      +/-   ##
==========================================
- Coverage   75.96%   74.59%   -1.38%     
==========================================
  Files         154      153       -1     
  Lines       15771    15148     -623     
==========================================
- Hits        11980    11299     -681     
- Misses       3791     3849      +58     

see 19 files with indirect coverage changes

@Stebalien
Copy link
Member

I usually edit the files manually.

cargo update ipld-core won't work because that just updates the lock file, not the requirement specified in the cargo.toml file.

There's a cargo upgrade command in the cargo-edit package for managing dependencies in Cargo.toml files but... that's tricky to use (it tends to upgrade everything) and I honestly don't like it unless I need to batch-upgrade a bunch of packages.

@Stebalien Stebalien merged commit 678e17f into master Feb 13, 2025
14 of 15 checks passed
@Stebalien Stebalien deleted the rvagg/upd-ipld branch February 13, 2025 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: ☑️ Done (Archive)
Development

Successfully merging this pull request may close these issues.

3 participants