Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to Rust 1.86.0 #2121

Merged
merged 2 commits into from
Apr 7, 2025
Merged

Update to Rust 1.86.0 #2121

merged 2 commits into from
Apr 7, 2025

Conversation

Stebalien
Copy link
Member

@Stebalien Stebalien commented Apr 4, 2025

This fixes a crash we were seeing in CI in v1.81.0.

@github-project-automation github-project-automation bot moved this to 📌 Triage in FilOz Apr 4, 2025
@codecov-commenter
Copy link

codecov-commenter commented Apr 4, 2025

Codecov Report

Attention: Patch coverage is 85.71429% with 1 line in your changes missing coverage. Please review.

Project coverage is 76.77%. Comparing base (7a45269) to head (88d99e9).

Files with missing lines Patch % Lines
shared/src/sys/mod.rs 0.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2121      +/-   ##
==========================================
- Coverage   76.83%   76.77%   -0.07%     
==========================================
  Files         149      149              
  Lines       15643    15631      -12     
==========================================
- Hits        12019    12000      -19     
- Misses       3624     3631       +7     
Files with missing lines Coverage Δ
fvm/src/engine/mod.rs 86.14% <100.00%> (ø)
fvm/src/machine/default.rs 69.47% <ø> (ø)
fvm/src/syscalls/event.rs 100.00% <ø> (ø)
fvm/src/syscalls/linker.rs 93.87% <ø> (ø)
fvm/src/syscalls/send.rs 100.00% <100.00%> (ø)
ipld/amt/src/diff.rs 85.52% <ø> (ø)
ipld/car/src/util.rs 80.39% <100.00%> (-0.38%) ⬇️
ipld/encoding/src/bytes.rs 79.66% <ø> (ø)
ipld/hamt/src/iter.rs 92.30% <ø> (ø)
ipld/hamt/src/node.rs 91.03% <100.00%> (+0.17%) ⬆️
... and 5 more

... and 10 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Stebalien Stebalien changed the title WIP: try updating to the latest rust Update to Rust 1.85.1 Apr 4, 2025
@Stebalien Stebalien requested a review from rvagg April 4, 2025 17:27
@Stebalien
Copy link
Member Author

We're going to need to be careful about updating rust in the builtin actors, but we'll need to do it eventually so we might as well do this now.

@Stebalien Stebalien marked this pull request as ready for review April 4, 2025 17:28
@Stebalien Stebalien force-pushed the steb/update-rust branch 5 times, most recently from e06aff1 to e4c6a99 Compare April 4, 2025 20:36
@rvagg
Copy link
Member

rvagg commented Apr 4, 2025

need to be careful about updating rust in the builtin actors

Can you describe how you would go about being careful other than pushing through and using existing integration tests to see what breaks? I guess digging through changelogs would be a start, but what else would you look for/at?

@Stebalien
Copy link
Member Author

@Stebalien Stebalien changed the title Update to Rust 1.85.1 Update to Rust 1.86.0 Apr 7, 2025
This fixes a crash in CI that showed up on v1.81.0.

Also fix a bunch of clippy warnings with `cargo clippy --fix`.
@BigLep BigLep moved this from 📌 Triage to 🔎 Awaiting Review in FilOz Apr 7, 2025
@github-project-automation github-project-automation bot moved this from 🔎 Awaiting Review to ✔️ Approved by reviewer in FilOz Apr 7, 2025
@Stebalien Stebalien merged commit 34dd64e into master Apr 7, 2025
15 checks passed
@Stebalien Stebalien deleted the steb/update-rust branch April 7, 2025 22:51
@github-project-automation github-project-automation bot moved this from ✔️ Approved by reviewer to 🎉 Done in FilOz Apr 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: 🎉 Done
Development

Successfully merging this pull request may close these issues.

3 participants