Update service-level-indicators/spark-retrieval-success-rate.md to describe how Spark v1.5 ingests DDO deals #238 #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Goddhi
requested review from
bajtos,
juliangruber and
patrickwoodhead
as code owners
bajtos
requested changes
Mar 5, 2025
|
|
||
| The `spark-deal-observer` works by monitoring the Filecoin network for new DDO deals and automatically adding them to the Spark Eligible Deal database. This process involves the following steps: | ||
|
|
||
| 1. **Event Listening**: The `spark-deal-observer` listens for events related to DDO deals on the Filecoin blockchain. |
There was a problem hiding this comment.
Let's be more specific here and explain: what event we listen for (claim) and how we calculate deal expiration time.
| The `spark-deal-observer` works by monitoring the Filecoin network for new DDO deals and automatically adding them to the Spark Eligible Deal database. This process involves the following steps: | ||
|
|
||
| 1. **Event Listening**: The `spark-deal-observer` listens for events related to DDO deals on the Filecoin blockchain. | ||
| 2. **Data Extraction**: When a new DDO deal is detected, the observer extracts relevant information, including the payload CID and the associated storage provider. |
There was a problem hiding this comment.
We need to be more specific here and explain how we leverage IPNI Advertisement metadata to discover payload CIDs advertised for a given PieceCID. The documentation should also explain how we convert a multihash found in advertised entries to a CID we can retrieve. (Answer: we assume Raw (0x55) codec and create a CID in v1 format.)
Comment on lines
+116
to
+117
| 3. **Database Update**: The extracted data is then formatted and inserted into the Spark Eligible Deal database, marking the deal as eligible for retrieval testing. | ||
| 4. **Real-Time Updates**: This process allows for immediate updates to the Spark system, meaning that new storage providers can be evaluated for their Spark scores without the previous delays associated with nightly batch processes. |
There was a problem hiding this comment.
The updates are not real-time:
- We are processing only events older than 8 hours to get high confidence in chain finality.
- The code updating the database of eligible deals picks only deals older than 48 hours (IIRC).
It's important to explain that in this document.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implementation introduces the spark-deal-observer pipeline for real-time ingestion of Direct Data Onboarding (DDO) deals in Spark v1.5. Key changes include: