-
-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature: Added support for bulk renaming items #15537
Conversation
t the same time We implemented the new functionality of renaming multiple items at the same time, so that way it is easier to do so. When the files have different extensions, the name stays the same, when it has the same extension, the name has a number attached to the end as it is requested int the issue. We did the behaviour to be similar to the Windows File Explorer. Co-authored-by: Rodrigo Leitao <[email protected]>
Could you provide a screen recording? |
I compiled this branch, but it seems to be missing the dialog when bulk renaming. |
Files_MultipleFileRename_record.mp4 |
@marianalcar the behavior seems to closely mimic File Explorer, while it technically works, we were hoping to add more advanced options in the future and therefore this feature requires a content dialog. |
We thought that was the expected behaviour since you mentioned previously on a pr. We'll look into that and do a content dialog. Can you be more specific in what the dialog should have? |
Sorry about the confusion! For now, the rename dialog should consist of a simple title and text box for entering the new name. In the future, we may want to add more options. |
2e4f94d
to
98eb6b4
Compare
@marianalcar are you still planning to work on this? |
@marianalcar I've made the requested changes in #16228. Can you take a look and comment if you have any feedback? |
Resolved / Related Issues
Previously, only one file could be renamed at the same time. We implemented the functionality of renaming multiple at the same time giving Files more flexibility and increased functionalities.
Steps used to test these changes